RFR: 8364503: gc/g1/TestCodeCacheUnloadDuringConcCycle.java fails because of race printing to stdout [v2]
David Holmes
dholmes at openjdk.org
Wed Aug 6 21:10:14 UTC 2025
On Mon, 4 Aug 2025 08:05:03 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Hi all,
>>
>> please review this change to the `gc/g1/TestCodeCacheUnloadDuringConcCycle.java` test - previously, the GC that we were waiting for in the test could occur between releasing whitebox control and the marker we use to distinguish before/after test setup.
>>
>> The change makes sure the marker is printed before releasing Whitebox control. So the concurrent start gc we look for can not happen before the marker printing.
>>
>> Testing: passes 5000 runs of that benchmark
>>
>> Thanks,
>> Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>
> * review ayang
Seems reasonable.
I am still curious why this suddenly started showing up.
Thanks
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26592#pullrequestreview-3094289377
More information about the hotspot-gc-dev
mailing list