RFR: 8364877: G1: Inline G1CollectedHeap::set_region_short_lived_locked
Albert Mingkun Yang
ayang at openjdk.org
Thu Aug 7 10:09:15 UTC 2025
On Wed, 6 Aug 2025 19:29:21 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> please review this change that inlines `G1CollectedHeap::set_region_short_lived_locked` - it's very small, and used only once in the same class, and has a very unusual name.
>
> Testing: gha
>
> Thanks,
> Thomas
src/hotspot/share/gc/g1/g1EdenRegions.hpp line 45:
> 43:
> 44: uint add(G1HeapRegion* hr) {
> 45: assert(hr->is_eden(), "should not already be set");
The string should be updated as well; maybe just "precondition" is fine.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26663#discussion_r2259793957
More information about the hotspot-gc-dev
mailing list