RFR: 8364934: G1: Rename members of G1CollectionSet [v3]
Kim Barrett
kbarrett at openjdk.org
Thu Aug 14 07:12:09 UTC 2025
On Thu, 7 Aug 2025 16:15:34 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Hi all,
>>
>> please review this renaming of various members of `G1CollectionSet` to
>>
>> - use the same prefixes for the regions ("_regions") and candidate groups ("_groups") consistently, avoiding adding prefixes here and there for no discernible reason
>> - remove unnecessary prefixes (`collection_set`) - everything is part of the collection set
>> - fix/improve some documentation
>>
>> Testing: gha
>>
>> Thanks,
>> THoams
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>
> * one more renaming: prepare_groups_for_scan() -> prepare_for_scan()
Looks good.
-------------
Marked as reviewed by kbarrett (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26670#pullrequestreview-3119281399
More information about the hotspot-gc-dev
mailing list