RFR: 8365571: GenShen: PLAB promotions may remain disabled for evacuation threads

[Kelvin Nilsen]

On Thu, 14 Aug 2025 18:15:00 GMT, William Kemper <wkemper at openjdk.org> wrote:

> Mutators and GC workers have old generation LABs for promotions and old generation evacuations. Priority is given to old evacuations by using a promotion budget. Once the promotion budget is exhausted, a thread local flag is set to disable further promotions (the LAB can still be used for old evacuations). This thread local flag is meant to be cleared to allow all threads to resume promotions on the next cycle. However, this flag is only reset for workers that perform thread root evacuations, which may not be the same workers that perform subsequent evacuations. This patch clears the flag for all threads when their LABs are retired at the end of evacuation.

Thank you for much improved code structure, and for fixing this bug.

Would be nice to share any improved performance results with this fix in place.

-------------

Marked as reviewed by kdnilsen (Committer).

PR Review: https://git.openjdk.org/jdk/pull/26785#pullrequestreview-3122435215