RFR: 8364934: G1: Rename members of G1CollectionSet [v4]
Thomas Schatzl
tschatzl at openjdk.org
Thu Aug 21 10:07:06 UTC 2025
> Hi all,
>
> please review this renaming of various members of `G1CollectionSet` to
>
> - use the same prefixes for the regions ("_regions") and candidate groups ("_groups") consistently, avoiding adding prefixes here and there for no discernible reason
> - remove unnecessary prefixes (`collection_set`) - everything is part of the collection set
> - fix/improve some documentation
>
> Testing: gha
>
> Thanks,
> THoams
Thomas Schatzl has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:
- Merge branch 'master' into 8364934-g1collectionset-renaming
- Merge branch 'master' into 8364934-g1collectionset-renaming
- * one more renaming: prepare_groups_for_scan() -> prepare_for_scan()
- Merge branch '8364925-improve-program-flow-inc-cset' into 8364934-g1collectionset-renaming
- * ayang review
- 8364934
Hi all,
please review this renaming of various members of `G1CollectionSet` to
- use the same prefixes
- remove unnecessary prefixes (`collection_set`)
- fix some documentation
Testing: gha
Thanks,
THoams
- * remove accidentally merged in JDK-8364934
- 8364925
Hi all,
please review this change that improves the G1CollectionSet incremental state handling slightly:
* remove `_selected_groups_cur_length` with getter as we do not need a copy of that value around
* move implementations of some methods from header files into cpp file
* moved some incremental state updates from `finalize_old_part` to the respective `start/continue/stop_incremental_building` method
Testing: gha
Thanks,
Thomas
-------------
Changes: https://git.openjdk.org/jdk/pull/26670/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26670&range=03
Stats: 115 lines in 7 files changed: 15 ins; 9 del; 91 mod
Patch: https://git.openjdk.org/jdk/pull/26670.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/26670/head:pull/26670
PR: https://git.openjdk.org/jdk/pull/26670
More information about the hotspot-gc-dev
mailing list