RFR: 8364934: G1: Rename members of G1CollectionSet [v5]

Albert Mingkun Yang ayang at openjdk.org
Thu Aug 21 11:51:52 UTC 2025


On Thu, 21 Aug 2025 11:04:19 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   please review this renaming of various members of `G1CollectionSet` to
>> 
>> - use the same prefixes for the regions ("_regions") and candidate groups ("_groups") consistently, avoiding adding prefixes here and there for no discernible reason
>> - remove unnecessary prefixes (`collection_set`) - everything is part of the collection set
>> - fix/improve some documentation
>> 
>> Testing: gha
>> 
>> Thanks,
>>   THoams
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   * undo unnecessarily added JDK-8365040

Marked as reviewed by ayang (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/26670#pullrequestreview-3140296907


More information about the hotspot-gc-dev mailing list