RFR: 8365052: G1: Remove G1CollectionSet::groups() accessors [v3]

Thomas Schatzl tschatzl at openjdk.org
Thu Aug 21 15:34:07 UTC 2025


> Hi all,
> 
>   please review this small change that remove the public `G1CollectionSet::groups()` accessors because they are never used from outside the `G1CollectionSet` class.
> 
> Testing: local compilation, gha
> 
> Thanks,
>   Thomas

Thomas Schatzl has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:

 - Merge branch 'master' into 8365052-remove-groups-accessors
 - 8365052
   
   Hi all,
   
     please review this small change that remove the public `G1CollectionSet::groups()` accessors because they are never used from outside the `G1CollectionSet` class.
   
   Testing: local compilation, gha
   
   Thanks,
     Thomas
 - * one more renaming: prepare_groups_for_scan() -> prepare_for_scan()
 - Merge branch '8364925-improve-program-flow-inc-cset' into 8364934-g1collectionset-renaming
 - * ayang review
 - 8364934
   
   Hi all,
   
     please review this renaming of various members of `G1CollectionSet` to
   
   - use the same prefixes
   - remove unnecessary prefixes (`collection_set`)
   - fix some documentation
   
   Testing: gha
   
   Thanks,
     THoams
 - * remove accidentally merged in JDK-8364934
 - 8364925
   
   Hi all,
   
     please review this change that improves the G1CollectionSet incremental state handling slightly:
   
   * remove `_selected_groups_cur_length` with getter as we do not need a copy of that value around
   * move implementations of some methods from header files into cpp file
   * moved some incremental state updates from `finalize_old_part` to the respective `start/continue/stop_incremental_building` method
   
   Testing: gha
   
   Thanks,
     Thomas

-------------

Changes: https://git.openjdk.org/jdk/pull/26688/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26688&range=02
  Stats: 5 lines in 3 files changed: 0 ins; 3 del; 2 mod
  Patch: https://git.openjdk.org/jdk/pull/26688.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/26688/head:pull/26688

PR: https://git.openjdk.org/jdk/pull/26688


More information about the hotspot-gc-dev mailing list