RFR: 8365024: G1: Make G1CollectionSet::_inc_build_state assert-only [v3]

[Thomas Schatzl]

On Thu, 21 Aug 2025 15:17:07 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains five commits:
>> 
>>  - Merge branch 'master' into 8365024-inc-cset-state-assert-only
>>  - 8365024
>>    
>>    Hi all,
>>    
>>      please review this change that makes the `G1CollectionSet::_inc_build_state` member debug/assert-only - it's only ever used in assertions.
>>    
>>    Testing: local compilation, gha
>>    
>>    Thanks,
>>      Thomas
>>  - 8364934
>>    
>>    Hi all,
>>    
>>      please review this renaming of various members of `G1CollectionSet` to
>>    
>>    - use the same prefixes
>>    - remove unnecessary prefixes (`collection_set`)
>>    - fix some documentation
>>    
>>    Testing: gha
>>    
>>    Thanks,
>>      THoams
>>  - * remove accidentally merged in JDK-8364934
>>  - 8364925
>>    
>>    Hi all,
>>    
>>      please review this change that improves the G1CollectionSet incremental state handling slightly:
>>    
>>    * remove `_selected_groups_cur_length` with getter as we do not need a copy of that value around
>>    * move implementations of some methods from header files into cpp file
>>    * moved some incremental state updates from `finalize_old_part` to the respective `start/continue/stop_incremental_building` method
>>    
>>    Testing: gha
>>    
>>    Thanks,
>>      Thomas
>
> Marked as reviewed by ayang (Reviewer).

Thanks @albertnetymk @kimbarrett for your reviews

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26671#issuecomment-3211113653