RFR: 8365040: G1: Remove sorting at end of collection set selection [v4]

Thomas Schatzl tschatzl at openjdk.org
Fri Aug 22 15:52:18 UTC 2025


> Hi all,
> 
>   please review this change to remove some unnecessary sorting of the collection set introduced in https://bugs.openjdk.org/browse/JDK-8165313, and made unnecessary in https://bugs.openjdk.org/browse/JDK-8165443 (all JDK 9 :)).
> 
> Testing: test case in CRs, see CR for test results, gha
> 
> Thanks,
>   Thomas

Thomas Schatzl has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:

 - Merge branch 'master' into 8365040-remove-collection-set-sorting
 - Merge branch 'master' into 8365040-remove-collection-set-sorting
 - 8365040
   
   Hi all,
   
     please review this change to remove some unnecessary sorting of the collection set introduced in https://bugs.openjdk.org/browse/JDK-8165313, and made unnecessary in https://bugs.openjdk.org/browse/JDK-8165443 (all JDK 9 :)).
   
   Testing: test case in CRs, gha
   
   Thanks,
     Thomas
 - 8364934
   
   Hi all,
   
     please review this renaming of various members of `G1CollectionSet` to
   
   - use the same prefixes
   - remove unnecessary prefixes (`collection_set`)
   - fix some documentation
   
   Testing: gha
   
   Thanks,
     THoams
 - * remove accidentally merged in JDK-8364934
 - 8364925
   
   Hi all,
   
     please review this change that improves the G1CollectionSet incremental state handling slightly:
   
   * remove `_selected_groups_cur_length` with getter as we do not need a copy of that value around
   * move implementations of some methods from header files into cpp file
   * moved some incremental state updates from `finalize_old_part` to the respective `start/continue/stop_incremental_building` method
   
   Testing: gha
   
   Thanks,
     Thomas

-------------

Changes: https://git.openjdk.org/jdk/pull/26676/files
  Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=26676&range=03
  Stats: 6 lines in 1 file changed: 0 ins; 6 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/26676.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/26676/head:pull/26676

PR: https://git.openjdk.org/jdk/pull/26676


More information about the hotspot-gc-dev mailing list