RFR: 8365034: G1: Remove num_groups_selected in G1CollectionSet::select_candidates_from_optional_groups as it is unnecessary [v4]
Albert Mingkun Yang
ayang at openjdk.org
Fri Aug 22 16:15:03 UTC 2025
On Fri, 22 Aug 2025 15:50:07 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Hi all,
>>
>> please review this removal of the local `num_selected_regions` from `G1CollectionSet::select_candidates_from_optional_groups()` - the same information is maintained within the local `selected_groups` list.
>>
>> Testing: gha
>>
>> Thanks,
>> Thomas
>
> Thomas Schatzl has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 14 commits:
>
> - * remove unwanted chagnes
> - Merge branch 'master' into 8365034-remove-unnecessary-num_selected_regions
> - Merge branch 'master' into 8365034-remove-unnecessary-num_selected_regions
> - * ayang review
> - Merge branch '8364934-g1collectionset-renaming' into 8365034-remove-unnecessary-num_selected_regions
> - Merge branch 'master' into 8364934-g1collectionset-renaming
> - Merge branch 'master' into 8364934-g1collectionset-renaming
> - * one more renaming: prepare_groups_for_scan() -> prepare_for_scan()
> - Merge branch '8364925-improve-program-flow-inc-cset' into 8364934-g1collectionset-renaming
> - * ayang review
> - ... and 4 more: https://git.openjdk.org/jdk/compare/e1c58f85...b9a66b12
Marked as reviewed by ayang (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/26674#pullrequestreview-3145076114
More information about the hotspot-gc-dev
mailing list