RFR: 8365040: G1: Remove sorting at end of collection set selection [v4]

Thomas Schatzl tschatzl at openjdk.org
Mon Aug 25 07:46:07 UTC 2025


On Fri, 22 Aug 2025 15:14:16 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
>> 
>>  - Merge branch 'master' into 8365040-remove-collection-set-sorting
>>  - Merge branch 'master' into 8365040-remove-collection-set-sorting
>>  - 8365040
>>    
>>    Hi all,
>>    
>>      please review this change to remove some unnecessary sorting of the collection set introduced in https://bugs.openjdk.org/browse/JDK-8165313, and made unnecessary in https://bugs.openjdk.org/browse/JDK-8165443 (all JDK 9 :)).
>>    
>>    Testing: test case in CRs, gha
>>    
>>    Thanks,
>>      Thomas
>>  - 8364934
>>    
>>    Hi all,
>>    
>>      please review this renaming of various members of `G1CollectionSet` to
>>    
>>    - use the same prefixes
>>    - remove unnecessary prefixes (`collection_set`)
>>    - fix some documentation
>>    
>>    Testing: gha
>>    
>>    Thanks,
>>      THoams
>>  - * remove accidentally merged in JDK-8364934
>>  - 8364925
>>    
>>    Hi all,
>>    
>>      please review this change that improves the G1CollectionSet incremental state handling slightly:
>>    
>>    * remove `_selected_groups_cur_length` with getter as we do not need a copy of that value around
>>    * move implementations of some methods from header files into cpp file
>>    * moved some incremental state updates from `finalize_old_part` to the respective `start/continue/stop_incremental_building` method
>>    
>>    Testing: gha
>>    
>>    Thanks,
>>      Thomas
>
> Marked as reviewed by iwalulya (Reviewer).

Thanks @walulyai @albertnetymk for your reviews

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26676#issuecomment-3219182467


More information about the hotspot-gc-dev mailing list