RFR: 8365052: G1: Remove G1CollectionSet::groups() accessors [v4]

[Thomas Schatzl]

On Mon, 25 Aug 2025 09:12:51 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains nine commits:
>> 
>>  - Merge branch 'master' into 8365052-remove-groups-accessors
>>  - Merge branch 'master' into 8365052-remove-groups-accessors
>>  - 8365052
>>    
>>    Hi all,
>>    
>>      please review this small change that remove the public `G1CollectionSet::groups()` accessors because they are never used from outside the `G1CollectionSet` class.
>>    
>>    Testing: local compilation, gha
>>    
>>    Thanks,
>>      Thomas
>>  - * one more renaming: prepare_groups_for_scan() -> prepare_for_scan()
>>  - Merge branch '8364925-improve-program-flow-inc-cset' into 8364934-g1collectionset-renaming
>>  - * ayang review
>>  - 8364934
>>    
>>    Hi all,
>>    
>>      please review this renaming of various members of `G1CollectionSet` to
>>    
>>    - use the same prefixes
>>    - remove unnecessary prefixes (`collection_set`)
>>    - fix some documentation
>>    
>>    Testing: gha
>>    
>>    Thanks,
>>      THoams
>>  - * remove accidentally merged in JDK-8364934
>>  - 8364925
>>    
>>    Hi all,
>>    
>>      please review this change that improves the G1CollectionSet incremental state handling slightly:
>>    
>>    * remove `_selected_groups_cur_length` with getter as we do not need a copy of that value around
>>    * move implementations of some methods from header files into cpp file
>>    * moved some incremental state updates from `finalize_old_part` to the respective `start/continue/stop_incremental_building` method
>>    
>>    Testing: gha
>>    
>>    Thanks,
>>      Thomas
>
> Marked as reviewed by ayang (Reviewer).

Thanks @albertnetymk @kimbarrett for your reviews

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26688#issuecomment-3219670530