RFR: 8365994: ZGC: Incorrect type signature in ZMappedCache comparator

Mon Aug 25 10:49:53 UTC 2025

On Fri, 22 Aug 2025 15:08:42 GMT, Joel Sikström <jsikstro at openjdk.org> wrote:

> Hello,
> 
> The comparator with two IntrusiveRBNode* in ZMappedCache has the incorrent type signature. This prevents IntrusiveRBTree from using the comparator as intended during validation, resulting in it using the fallback verify function, which always returns true. This could mask potential issues in the tree structure. 
> 
> Testing:
> * Manually placing an assert in the fallback verify function to see if it is used. It is no longer used with this patch.
> * Oracle's tier 1-2

Good catch.

-------------

Marked as reviewed by aboldtch (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26904#pullrequestreview-3150892756