RFR: 8359683: ZGC: NUMA-Aware Relocation [v3]

Joel Sikström jsikstro at openjdk.org
Mon Aug 25 15:00:29 UTC 2025


On Mon, 25 Aug 2025 13:07:08 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> Joel Sikström has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Rename initiating_numa_id to preferred_partition
>
> src/hotspot/share/gc/z/zPageAllocator.cpp line 2200:
> 
>> 2198:          is_multi_partition_enabled() &&
>> 2199:          sum_available() >= allocation->size();
>> 2200: }
> 
> Thanks for addressing my comments, if I'm being picky I would prefer this order of the statements. If you prefer the current I'm ok with this as well.
> 
> Suggestion:
> 
>   return is_multi_partition_enabled() &&
>          allocation->type() == ZPageType::large &&
>          allocation->size() <= sum_available();
> }

I agree!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26898#discussion_r2298348869


More information about the hotspot-gc-dev mailing list