RFR: 8359348: G1: Improve cpu usage measurements for heap sizing [v4]

[Thomas Schatzl]

On Tue, 19 Aug 2025 12:43:46 GMT, Ivan Walulya <iwalulya at openjdk.org> wrote:

>> Hi,
>> 
>> Please review this patch which takes into account the impact of concurrent GC activity on mutator threads when computing the time spent on GC activity in a time interval. Previously, only the GC pause times were considered, and the overhead imposed by concurrent GC worker threads was not included.
>> 
>> With this change, we now estimate the impact of concurrent GC by dividing `elapsed_gc_cpu_time` by the number of CPUs. This provides an approximation of the additional time attributable to GC activity, assuming a fair CPU resource sharing.  Although this method does not account for contention on other shared resources (such as memory bandwidth or caches), it offers a reasonable estimate for most scenarios.
>> 
>> Testing: Tier 1
>
> Ivan Walulya has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:
> 
>  - Merge remote-tracking branch 'upstream/master' into ConcCPUImpact
>  - accumlate concurrent_gc_impact_time
>  - Merge remote-tracking branch 'upstream/master' into ConcCPUImpact
>  - cleanup after merge
>  - Merge remote-tracking branch 'upstream/master' into ConcCPUImpact
>  - Merge branch 'NormalizeTiming' into ConcCPUImpact
>  - Thomas suggestion
>  - Thomas Review
>  - reorder
>  - concurrent gc impact
>  - ... and 2 more: https://git.openjdk.org/jdk/compare/999761d0...c65429ad

Looks good.

src/hotspot/share/gc/g1/g1Analytics.hpp line 142:

> 140:     return _concurrent_gc_cpu_time_ms;
> 141:   }
> 142: 

Now this method is unused :)

-------------

Marked as reviewed by tschatzl (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26351#pullrequestreview-3154659056
PR Review Comment: https://git.openjdk.org/jdk/pull/26351#discussion_r2300305738