RFR: 8366462: Test gc/z/TestCommitFailure.java#Normal failed: expected output missing

[David Holmes]

On Sun, 31 Aug 2025 10:26:28 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

> The newly introduced test is intermittently failing where it tries to verify that we got a commit failure. I suggest we simply remove this verification as an initial fix. 
> 
> Trying to reproduce these failure paths reliably with a blackbox test is probably not possible. So we would have to extend the JVM with whitebox hooks for doing exactly what we want. I think we need to be very careful in such a design to not affect the maintainability and readability to the code. 
> 
> For now it is enough that this test intermittently exercises the commit failure paths and intermittently would reproduce any regressions. 
> 
> The risk is having to be more diligent in the future with checking that this test still works when changing ZPageAllocator policies or implementation details.

As at least a short term remedy this seems fine - thanks. GC team can figure out a longer term strategy for this aspect of testing.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27023#pullrequestreview-3171842649