Integrated: 8372610: G1: JDK-8297692 broke code roots scan measurements
Thomas Schatzl
tschatzl at openjdk.org
Mon Dec 1 11:31:00 UTC 2025
On Wed, 26 Nov 2025 16:35:52 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> please review this change that fixes "Code Root Scan" logging - a wrong scope for the timing measurements made these values always print `0.00` and the duration moved to the "Other time" category.
>
> E.g. without patch:
>
>
> [1.121s][debug][gc,phases] GC(7) Code Root Scan (ms): Min: 0.00, Avg: 0.00, Max: 0.00, Diff: 0.00, Sum: 0.00, Workers: 4
> [1.485s][debug][gc,phases] GC(8) Code Root Scan (ms): Min: 0.00, Avg: 0.00, Max: 0.00, Diff: 0.00, Sum: 0.00, Workers: 8
> [1.715s][debug][gc,phases] GC(9) Code Root Scan (ms): Min: 0.00, Avg: 0.00, Max: 0.00, Diff: 0.00, Sum: 0.00, Workers: 8
>
>
> with patch:
>
>
> [1.392s][debug][gc,phases] GC(7) Code Root Scan (ms): Min: 0.00, Avg: 0.03, Max: 0.12, Diff: 0.12, Sum: 0.21, Workers: 8
> [1.638s][debug][gc,phases] GC(8) Code Root Scan (ms): Min: 0.00, Avg: 0.03, Max: 0.15, Diff: 0.15, Sum: 0.26, Workers: 8
> [1.862s][debug][gc,phases] GC(9) Code Root Scan (ms): Min: 0.00, Avg: 0.03, Max: 0.16, Diff: 0.15, Sum: 0.26, Workers: 8
>
>
> Testing: gha, local checking
>
> Thanks,
> Thomas
This pull request has now been integrated.
Changeset: 160148cc
Author: Thomas Schatzl <tschatzl at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/160148cc7b0c2774e7aa5fece653e41c9fa7c970
Stats: 15 lines in 1 file changed: 7 ins; 6 del; 2 mod
8372610: G1: JDK-8297692 broke code roots scan measurements
Reviewed-by: iwalulya, sjohanss
-------------
PR: https://git.openjdk.org/jdk/pull/28513
More information about the hotspot-gc-dev
mailing list