RFR: 8373025: Test: test/hotspot/jtreg/gc/cslocker/TestCSLocker.java may deadlock
Axel Boldt-Christmas
aboldtch at openjdk.org
Wed Dec 3 15:22:16 UTC 2025
The main threads call to `csLocker.unlock();` may cause an allocation which may trigger a GC. This can lead to a deadlock because we have a native thread which is waiting on a signal from the main thread (which is sent in `csLocker.unlock()`) to `ReleasePrimitiveArrayCritical`. Without the call to ReleasePrimitiveArrayCritical the some GCs may be blocked.
I suggest we remove the dependency on a java thread for the `GetPrimitiveArrayCritical` / `ReleasePrimitiveArrayCritical` pair. And simply do the lock and the sleep inside native.
* Testing
* Stress testing test/hotspot/jtreg/gc/cslocker/TestCSLocker.java with both SerialGC and ZGC and small heap sizes
* GHA
-------------
Commit messages:
- Fix the comment
- 8373025: Test: test/hotspot/jtreg/gc/cslocker/TestCSLocker.java may deadlock
Changes: https://git.openjdk.org/jdk/pull/28638/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=28638&range=00
Issue: https://bugs.openjdk.org/browse/JDK-8373025
Stats: 33 lines in 2 files changed: 5 ins; 22 del; 6 mod
Patch: https://git.openjdk.org/jdk/pull/28638.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/28638/head:pull/28638
PR: https://git.openjdk.org/jdk/pull/28638
More information about the hotspot-gc-dev
mailing list