RFR: 8319161: GC: Make TestParallelGCThreads use createTestJavaProcessBuilder [v2]

Ivan Walulya iwalulya at openjdk.org
Mon Dec 8 10:18:03 UTC 2025


On Tue, 2 Dec 2025 08:56:28 GMT, Ramkumar Sunderbabu <rsunderbabu at openjdk.org> wrote:

>> Summary of change:
>> 
>> 1. executeLimitedTestJava changed to executeTestJava to allow flags to be propagated to forked processes.
>> 2. Test is split into separate sections pertaining to GC requirements. @requires now has corresponding GC flag condition.
>> 3. Addition of ZGC to list of parallel collectors
>> 
>> Testing:
>> HS Tiers 1 and 2
>> Ran with all flag combinations in CI
>
> Ramkumar Sunderbabu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   separating test sections

Looks good!

Nit:

test/hotspot/jtreg/gc/arguments/TestParallelGCThreads.java line 156:

> 154:   }
> 155: 
> 156:   private static void testMaxValue() throws Exception {

Could be helpful to have a comment on why we use SerialGC for this test. However, that is pre-existing, so you can ignore.

-------------

Marked as reviewed by iwalulya (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28566#pullrequestreview-3551226661
PR Review Comment: https://git.openjdk.org/jdk/pull/28566#discussion_r2597952886


More information about the hotspot-gc-dev mailing list