RFR: 8373225: GenShen: More adaptive old-generation growth heuristics [v5]
Y. Srinivas Ramakrishna
ysr at openjdk.org
Thu Dec 11 00:58:34 UTC 2025
On Thu, 11 Dec 2025 00:09:12 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
>> src/hotspot/share/gc/shenandoah/shenandoahOldGeneration.cpp line 119:
>>
>>> 117: _card_scan(nullptr),
>>> 118: _state(WAITING_FOR_BOOTSTRAP),
>>> 119: _growth_percent_before_compaction(INITIAL_PERCENT_GROWTH_BEFORE_COMPACTION)
>>
>> Use either "percent_growth" or "growth_percent" consistently in both names.
>
> And make those two consistent with either "percent_live" or "live_percent" below.
>
> (These comments from me actually belong in the .hpp where these are defined.)
I think "percent" at the end makes sense, so "live_percent" and "growth_percent", so only the "initial growth percent" name needs to be adjusted for consistency.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28561#discussion_r2608654130
More information about the hotspot-gc-dev
mailing list