RFR: 8373225: GenShen: More adaptive old-generation growth heuristics [v5]

[Kelvin Nilsen]

On Wed, 10 Dec 2025 23:01:38 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove FRACTIONAL_DENOMINATOR constat
>
> src/hotspot/share/gc/shenandoah/shenandoahGeneration.cpp line 509:
> 
>> 507: 
>> 508: // Preselect for inclusion into the collection set regions whose age is at or above tenure age which contain more than
>> 509: // the old garbage threshold amount of garbage.  We identify these regions by setting the appropriate entry of
> 
> Is amount in this sentence a percentage? If so, I'd say: `We only select regions whose garbage percentage exceeds a dynamically adjusted threshold.`
> Using "old garbage threshold amount" by itself can be confusing, since "amount" doesn't sound like a percentage which is what I believe we mean here.

I've word-smithed your suggestion into the existing paragraph .  Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28561#discussion_r2611304065