RFR: 8372250: Merge PtrQueue into SATBMarkQueue [v3]

Kim Barrett kbarrett at openjdk.org
Fri Dec 12 04:33:50 UTC 2025


On Thu, 11 Dec 2025 16:41:24 GMT, Ben Taylor <btaylor at openjdk.org> wrote:

>> This change merges `PtrQueue` into its only child class, `SATBMarkQueue`. The corresponding `PtrQueueSet` is merged with `SATBMarkQueueSet`, and `G1SATBMarkQueueSet` and `ShenandoahSATBMarkQueueSet` continue to inherit from that class.
>> 
>> There are few code modifications - most methods were moved directly from `PtrQueue` to `SATBMarkQueue`. The one meaningful change is to  preserve `SATBMarkQueue`'s call to `filter(queue);` before `flush_queue`. 
>> 
>> This change passes all tier1 jtreg tests with both Shenandoah and G1 in local testing.
>
> Ben Taylor has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove virtual from SATBMarkQueueSet::enqueue_completed_buffer

Looks good.

-------------

Marked as reviewed by kbarrett (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/28755#pullrequestreview-3570252361


More information about the hotspot-gc-dev mailing list