RFR: 8373100: Genshen: Control thread can miss allocation failure notification [v2]

[William Kemper]

On Sat, 13 Dec 2025 00:03:10 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Set requested gc cause under a lock when allocation fails
>
> Thanks for cleaning this up.
> 
> Did you review the non-generational ShenandoahControlThread and uses thereof to make sure a similar issues doesn't exist there?
> 
> As Xiaolong states, it might be worthwhile to do a refactor that shares as much as needed and no more, and to do so cleanly.
> 
> This looks good; sorry for the delay in reviewing.
> 
> 🚢

@ysramakrishna , @pengxiaolong - The non-generational control thread is less susceptible to this sort of issue because it has the responsibility of evaluating trigger conditions. It's loop therefore sleeps with a timed wait when the GC cycle is complete. If it misses a cancelled gc request, it will see it on the next iteration.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28665#issuecomment-3648576231