RFR: 8348171: Refactor GenerationCounters and its subclasses [v4]

Zhengyu Gu zgu at openjdk.org
Sat Feb 1 16:42:50 UTC 2025


On Fri, 31 Jan 2025 12:30:30 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Simple refactoring of removing the use of `virtual` method and use concrete subclasses when needed.
>> 
>> Test: tier1-5
>
> Albert Mingkun Yang has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - review
>  - * some more refactoring

src/hotspot/share/gc/shenandoah/shenandoahMonitoringSupport.cpp line 39:

> 37:           GenerationCounters("Young", 0, 0, 0, (size_t)0, (size_t)0) {};
> 38: 
> 39:   void update_all() {

Shenandoah looks a bit odd now. @kdnilsen @wkemper and @ysramakrishna may want to take a look?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23209#discussion_r1938303987


More information about the hotspot-gc-dev mailing list