RFR: 8349213: G1: Clearing bitmaps during collection set merging not claimed by region [v2]

Thomas Schatzl tschatzl at openjdk.org
Tue Feb 4 10:35:44 UTC 2025


On Tue, 4 Feb 2025 09:19:04 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   * ayang review
>
> src/hotspot/share/gc/g1/g1RemSet.cpp line 1390:
> 
>> 1388:         g1h->collection_set_iterate_increment_from(&merge, worker_id);
>> 1389:         for (uint i = 0; i < G1GCPhaseTimes::MergeRSContainersSentinel; i++) {
>> 1390:           p->record_or_add_thread_work_item(merge_remset_phase, worker_id, merge.stats().merged(i), i);
> 
> `stats()` has side-effect; should be invoked only once.

Nice catch! Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23419#discussion_r1940911005


More information about the hotspot-gc-dev mailing list