RFR: 8348268: Test gc/shenandoah/TestResizeTLAB.java#compact: fatal error: Before Updating References: Thread C2 CompilerThread1: expected gc-state 9, actual 21

[William Kemper]

On Tue, 4 Feb 2025 16:03:02 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Non-java threads were not having their gc-state configured when they attach. If they were created before the verifier's safepoint, but after the iteration over non-java threads, they would not have the correct state.
>
> It looks generally okay, but I am confused how this fixes a bad state in `C2 CompilerThread1`, since compiler threads are Java threads? https://github.com/openjdk/jdk/blob/beb43e2633900bb9ab3c975376fe5860b6d054e0/src/hotspot/share/compiler/compilerThread.hpp#L42

@shipilev , that is a good point. Will take a closer look.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23428#issuecomment-2634609075