RFR: 8343782: G1: Use one G1CardSet instance for multiple old gen regions [v10]
Ivan Walulya
iwalulya at openjdk.org
Wed Feb 5 13:48:20 UTC 2025
On Mon, 23 Dec 2024 21:03:16 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Yes, retained regions are in "single region" groups, so all details should be added to the log when we call `do_heap_region`
>
> I see; however, this would print the same gc_eff twice if young-gen contains a single region, right? Since this method is about cset-groups, I think it's more natural to visit all groups (regardless their size) here. With this PR, there is no gc_eff associated with individual region, `do_heap_region` can just skip gc_eff.
fixed, creating another issue; now we don't print details on humongous regions. I ask we fix that in a follow up.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22015#discussion_r1942972818
More information about the hotspot-gc-dev
mailing list