RFR: 8348595: GenShen: Fix generational free-memory no-progress check [v3]

Paul Hohensee phh at openjdk.org
Tue Feb 11 14:20:12 UTC 2025


On Tue, 11 Feb 2025 04:08:48 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> At the end of a degenerated GC, we check whether sufficient progress has been made in replenishing the memory available to the mutator. The test for good progress is implemented as a ratio of free memory against the total heap size.
>> 
>> For generational Shenandoah, the ratio should be computed against the size of the young generation. Note that the size of the generational collection set is based on young generation size rather than total heap size.
>> 
>> This issue first identified in GenShen GC logs, where a large number of degenerated cycles were upgrading to full GC because the free-set progress was short of desired by 10-25%.
>
> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add comments suggested by reviewers

Looks good.

-------------

Marked as reviewed by phh (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23306#pullrequestreview-2608901033


More information about the hotspot-gc-dev mailing list