RFR: 8349836: G1: Improve group prediction log message [v2]

Albert Mingkun Yang ayang at openjdk.org
Wed Feb 12 16:02:12 UTC 2025


On Wed, 12 Feb 2025 15:42:49 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:

>> Hi all,
>> 
>>   please review this minor change to the group prediction log message
>> printed with gc+ergo+cset=trace:
>> 
>>   * add group id to be able to refer to something concrete when discussing results
>>   * add total time
>>   * fix typo in `bytes_to_cop`
>> 
>> Testing: gha, local verification
>> 
>> `Group 10: 5 regions prediction total_time 20.0ms card_rs_length 123456 merge_scan_time 10.2ms code_root_scan_time_ms 5.5ms evac_time_ms 3.7ms other_time 0.3ms bytes_to_copy 1234567`
>> 
>> instead of
>> 
>> `Prediction for group with 76 regions, card_rs_length 320, merge_scan_time 0.02ms, code_root_scan_time_ms 0.00ms, evac_time_ms 9.92ms, other_time 45.60ms, bytes_to_cop 61408560`
>> 
>> Thanks,
>>   Thomas
>
> Thomas Schatzl has updated the pull request incrementally with one additional commit since the last revision:
> 
>   ayang review

Marked as reviewed by ayang (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/23562#pullrequestreview-2612435747


More information about the hotspot-gc-dev mailing list