RFR: 8349094: GenShen: Race between control and regulator threads may violate assertions [v12]

William Kemper wkemper at openjdk.org
Mon Feb 24 18:23:56 UTC 2025


On Sat, 15 Feb 2025 01:14:03 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahCollectorPolicy.hpp line 101:
>> 
>>> 99:         || cause == GCCause::_shenandoah_allocation_failure_evac
>>> 100:         || cause == GCCause::_shenandoah_humongous_allocation_failure;
>>> 101:   }
>> 
>> Would it make sense to move this implementation also to the .cpp file like the other static `is_...` methods below?
>
> Or is this guaranteeing inlining into the caller's body, which you might prefer for the callers?

I moved the implementation.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23475#discussion_r1968193533


More information about the hotspot-gc-dev mailing list