RFR: 8349094: GenShen: Race between control and regulator threads may violate assertions [v14]

[William Kemper]

On Wed, 26 Feb 2025 01:24:18 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp line 687:
>> 
>>> 685:   HeapWord* allocate_from_gclab_slow(Thread* thread, size_t size);
>>> 686:   HeapWord* allocate_new_gclab(size_t min_size, size_t word_size, size_t* actual_size);
>>> 687:   bool retry_allocation(size_t original_full_gc_count) const;
>> 
>> It feels like this should be called `should_retry_allocation()`. Also a 1-line documentation comment: ``` // We want to retry an unsuccessful attempt at allocation until at least a full gc. ```
>
> PS: do we know that a full gc will reclaim all soft refs? I suppose that is Shenandoah policy?

Yes, I like that name better. And yes, full gc will reclaim all soft refs.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23475#discussion_r1972342529