RFR: 8350889: GenShen: Break out of infinite loop of old GC cycles

[Y. Srinivas Ramakrishna]

On Thu, 27 Feb 2025 16:58:49 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

> Add log message when heuristic trigger because previous trigger is pending.  Cancel the pending-trigger condition for old-generation at the start of old-generation GC.

Changes look good. A somewhat tangential comment (possibly a nit) on old (existing) code.

src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.cpp line 246:

> 244:     log_trigger("GC start is already pending");
> 245:     return true;
> 246:   }

Should this happen lower down? Otherwise you miss the sampling of allocation rate at this time, down at line 249. Not sure if that can be an issue. Perhaps not and you just interpolate an average over the duration since the last sample albeit missing the occasional spike or dip, with perhaps the resulting low-pass filtering here ok? It would be OK if there is not an expectation of roughly syncrhonous sampling. Depends on how the code at line 286 works, I guess.

-------------

Marked as reviewed by ysr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23827#pullrequestreview-2648522862
PR Review Comment: https://git.openjdk.org/jdk/pull/23827#discussion_r1974023918