RFR: 8347804: GenShen: Crash with small GCCardSizeInBytes and small Java heap [v2]

[Kelvin Nilsen]

On Thu, 27 Feb 2025 19:22:31 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp line 950:
>> 
>>> 948:   ShenandoahHeap* const heap = ShenandoahHeap::heap();
>>> 949:   assert(heap->is_concurrent_weak_root_in_progress(), "Only during this phase");
>>> 950:   {
>> 
>> This looks like it came from https://github.com/openjdk/jdk/pull/23604. Did you cherry-pick that into this branch? Not sure why it shows in the diff here.
>
> Looks like I accidentally did cherry-pick into my gitfarm variant of this branch, and then merged into the github version of the branch.  The merge history must have gotten confused.

would it help if I cherry-pick the same commit directly into github?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23373#discussion_r1974209324