RFR: 8344049: Shenandoah: Eliminate init-update-refs safepoint [v2]
William Kemper
wkemper at openjdk.org
Thu Jan 9 17:47:26 UTC 2025
> Shenandoah typically takes 4 safepoints per GC cycle. Although Shenandoah itself does not spend much time on these safepoints, it may still take quite some time for all of the mutator threads to reach the safepoint. The occasionally long time-to-safepoint increases latency in the higher percentiles.
>
> The `init-update-refs` safepoint is responsible for retiring GCLABs (and PLABs) used during evacuation. Once evacuation is complete, no threads will access these LABs. This need not be done on a safepoint. `init-update-refs` is also where the global and thread local copies of the `gc_state` are updated. However, here we are turning off the `WEAK_ROOTS` flag _after_ all of the unmarked weak referents have been `nulled` out, so this does not need to happen atomically with respect to the mutators. Neither is it necessary to change the other state flags (EVACUATION, UPDATE_REFS) atomically across all mutators.
>
> Note that the `init-update-refs` safepoint is still taken if either verification or `ShenandoahPacing` are enabled.
William Kemper has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 32 additional commits since the last revision:
- Improve comments
- Merge remote-tracking branch 'jdk/master' into remove-init-update-refs-safepoint
- Fix comments
- Fix comment, revert unnecessary change
- Merge remote-tracking branch 'jdk/master' into remove-init-update-refs-safepoint
- Fix phase encoding to handle weak roots
- WIP: Use Threads::threads_do for propagating gc state (consolidated)
- WIP: Use Threads::threads_do for propagating gc state
- Remove unnecessary gc state propagations
- Encapsulate gc state
- ... and 22 more: https://git.openjdk.org/jdk/compare/967c77a7...83ac7b49
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/22688/files
- new: https://git.openjdk.org/jdk/pull/22688/files/9aaef708..83ac7b49
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=22688&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=22688&range=00-01
Stats: 31726 lines in 2167 files changed: 20848 ins; 5389 del; 5489 mod
Patch: https://git.openjdk.org/jdk/pull/22688.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/22688/head:pull/22688
PR: https://git.openjdk.org/jdk/pull/22688
More information about the hotspot-gc-dev
mailing list