RFR: 8338737: Shenandoah: Reset marking bitmaps after the cycle [v3]

Xiaolong Peng xpeng at openjdk.org
Thu Jan 9 19:28:08 UTC 2025


On Wed, 8 Jan 2025 22:46:12 GMT, Xiaolong Peng <xpeng at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp line 242:
>> 
>>> 240:   // Instead of always reset before collect, some reset can be done after collect to save
>>> 241:   // the time before before the cycle so the cycle can be started as soon as possible.
>>> 242:   entry_reset_after_collect();
>> 
>> For comment, I would say: "Instead of always resetting immediately before the start of a new GC, we can often reset at the end of the previous GC.  This allows us to start the next GC cycle more quickly after a trigger condition is detected, reducing the likelihood that GC will degenerate."
>
> I'll update comments, thanks Kelvin!

Fixed. thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22778#discussion_r1909330187


More information about the hotspot-gc-dev mailing list