RFR: 8344049: Shenandoah: Eliminate init-update-refs safepoint [v3]
William Kemper
wkemper at openjdk.org
Mon Jan 13 18:32:47 UTC 2025
On Sat, 11 Jan 2025 01:35:06 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Improve comments and method names
>
> src/hotspot/share/gc/shenandoah/shenandoahConcurrentGC.cpp line 196:
>
>> 194:
>> 195: // Evacuation is complete, retire gc labs
>> 196: heap->concurrent_prepare_for_update_refs();
>
> For consistency with other related method naming, can we use "updaterefs" instead of "update_refs" (makes IDE searches easier to locate related methods).
I'm all for making this consistent, but it seems that `update_refs` is more commonly used in method and variable declarations:
[0] % grep -r --include "*.hpp" updaterefs src/hotspot/share/gc/shenandoah | wc -l
17
[0] % grep -r --include "*.hpp" update_refs src/hotspot/share/gc/shenandoah | wc -l
27
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22688#discussion_r1913637958
More information about the hotspot-gc-dev
mailing list