RFR: 8344049: Shenandoah: Eliminate init-update-refs safepoint [v4]

William Kemper wkemper at openjdk.org
Mon Jan 13 18:45:23 UTC 2025


> Shenandoah typically takes 4 safepoints per GC cycle. Although Shenandoah itself does not spend much time on these safepoints, it may still take quite some time for all of the mutator threads to reach the safepoint. The occasionally long time-to-safepoint increases latency in the higher percentiles.
> 
> The `init-update-refs` safepoint is responsible for retiring GCLABs (and PLABs) used during evacuation. Once evacuation is complete, no threads will access these LABs. This need not be done on a safepoint. `init-update-refs` is also where the global and thread local copies of the `gc_state` are updated. However, here we are turning off the `WEAK_ROOTS` flag _after_ all of the unmarked weak referents have been `nulled` out, so this does not need to happen atomically with respect to the mutators. Neither is it necessary to change the other state flags (EVACUATION, UPDATE_REFS) atomically across all mutators.
> 
> Note that the `init-update-refs` safepoint is still taken if either verification or `ShenandoahPacing` are enabled.

William Kemper has updated the pull request incrementally with two additional commits since the last revision:

 - Encapsulate and document a method for making concurrent gc_state changes
 - Control thread doesn't need a gc lab, also make gclabs for safepoint workers parsable

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22688/files
  - new: https://git.openjdk.org/jdk/pull/22688/files/89c20a14..26e382c5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22688&range=03
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22688&range=02-03

  Stats: 21 lines in 2 files changed: 14 ins; 3 del; 4 mod
  Patch: https://git.openjdk.org/jdk/pull/22688.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22688/head:pull/22688

PR: https://git.openjdk.org/jdk/pull/22688


More information about the hotspot-gc-dev mailing list