RFR: 8347732: Replace SIZE_FORMAT in shenandoah [v3]

Coleen Phillimore coleenp at openjdk.org
Wed Jan 15 21:35:42 UTC 2025


On Wed, 15 Jan 2025 13:24:19 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Please review this change to replace SIZE_FORMAT with %zu in the shenandoah directories.  The goal is for one of these changes to remove SIZE_FORMAT so this change is necessary.  Most was done with a script, except the SIZE_FORMAT_W(10) in print_gc_stats which was changed manually to retain the formatting.
>> Tested with building shenandoah and tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix merge.

The strings are nicer with "pre string %zu all the rest of the things", rather than "pre string " SIZE_FORMAT " all the rest of the things".  i.e. nicer to not have these macros that aren't necessary.

Don't you think they look nicer?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23134#issuecomment-2593979980


More information about the hotspot-gc-dev mailing list