RFR: 8347732: Replace SIZE_FORMAT in shenandoah [v3]
Y. Srinivas Ramakrishna
ysr at openjdk.org
Thu Jan 16 00:55:38 UTC 2025
On Wed, 15 Jan 2025 13:24:19 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Please review this change to replace SIZE_FORMAT with %zu in the shenandoah directories. The goal is for one of these changes to remove SIZE_FORMAT so this change is necessary. Most was done with a script, except the SIZE_FORMAT_W(10) in print_gc_stats which was changed manually to retain the formatting.
>> Tested with building shenandoah and tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix merge.
That's a ton of changes. Thank you so much for taking the time to fix these (hopefully via a script).
🚢
src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.cpp line 4:
> 2: * Copyright (c) 2018, 2019, Red Hat, Inc. All rights reserved.
> 3: * Copyright Amazon.com Inc. or its affiliates. All Rights Reserved.
> 4: * Copyright (c) 2025, Oracle and/or its affiliates. All rights reserved.
Is it normal to update copyright header for changes such as this, i.e. for small cosmetic changes too? (In the past we got somewhat different feedback on this.)
-------------
Marked as reviewed by ysr (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23134#pullrequestreview-2554424763
PR Review Comment: https://git.openjdk.org/jdk/pull/23134#discussion_r1917515102
More information about the hotspot-gc-dev
mailing list