RFR: 8346572: Check is_reserved() before using ReservedSpace instances

[Stefan Karlsson]

On Thu, 19 Dec 2024 09:35:33 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> There are a number of places where we reserve memory and create a ReservedSpace, and after the use the created instance without checking if the memory actually got reserved and the instance got initialized. This mostly affects code paths during JVM initialization and fixing this will mostly give better error handling and tracing.
> 
> The patch also includes some minor restructuring to get early returns and remove redundant null checks after calls to new.
> 
> Tested tier1 and GHA, but will run more tests when/if this gets accepted.

Thanks for the reviews!

Shenandoah devs, what should I do about the comment I added in shenandoahHeap.cpp? Do you want to handle that in this patch, should I leave the comment, or should I remove it?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22825#issuecomment-2595108090