RFR: 8347730: Replace SIZE_FORMAT in g1
Coleen Phillimore
coleenp at openjdk.org
Thu Jan 16 14:25:45 UTC 2025
On Thu, 16 Jan 2025 14:16:26 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Please review this change to replace SIZE_FORMAT with %zu in the g1 directory. Most edits were by script but SIZE_FORMAT_W(n) was done sort of by hand. Also fixed one place where preexisting formatting was bad.
>>
>> Tested all the GC changes together (other PRs coming) with tier1-4 on x86 and aarch64.
>
> src/hotspot/share/gc/g1/g1MonitoringSupport.cpp line 293:
>
>> 291: // _old_gen_committed is calculated in terms of _old_gen_used value.
>> 292: assert(_old_gen_used <= _old_gen_committed, "Old gen used bytes(%zu"
>> 293: ") should be less than or equal to old gen committed(%zu)",
>
> Move the first close paren to the previous line in these two changes.
Okay, I tried to find these strange formats but missed this one.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23114#discussion_r1918650244
More information about the hotspot-gc-dev
mailing list