RFR: 8346572: Check is_reserved() before using ReservedSpace instances [v2]

[William Kemper]

On Thu, 23 Jan 2025 12:40:06 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> There are a number of places where we reserve memory and create a ReservedSpace, and after the use the created instance without checking if the memory actually got reserved and the instance got initialized. This mostly affects code paths during JVM initialization and fixing this will mostly give better error handling and tracing.
>> 
>> The patch also includes some minor restructuring to get early returns and remove redundant null checks after calls to new.
>> 
>> Tested tier1 and GHA, but will run more tests when/if this gets accepted.
>
> Stefan Karlsson has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits:
> 
>  - Merge remote-tracking branch 'upstream/master' into 8346572_check_is_reserved
>  - 8346572: Check is_reserved() before using ReservedSpace instances

Filed https://bugs.openjdk.org/browse/JDK-8348420 to follow up for Shenandoah.

-------------

Marked as reviewed by wkemper (Committer).

PR Review: https://git.openjdk.org/jdk/pull/22825#pullrequestreview-2570660032