RFR: 8359110: Log accumulated GC and process CPU time upon VM exit [v12]
Jonas Norlinder
duke at openjdk.org
Tue Jul 1 09:35:43 UTC 2025
On Tue, 1 Jul 2025 07:08:45 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> Jonas Norlinder has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Update closure name
>> - vtime -> cpu_time and _vm_vtime -> _vmthread_cpu_time
>
> src/hotspot/share/runtime/os.hpp line 296:
>
>> 294: static jlong elapsed_frequency();
>> 295:
>> 296: static double elapsed_process_cpu_time();
>
> Not sure if it is required that these methods return their values as `double`s in seconds. Given the uses, this seems unnecessary premature loss of precision.
It is not required, but I was conforming to the same type as the methods that was removed in JDK-8274051 and as well as `elapsedTime()`. `elapsedTime()` returns the wall-clock time in seconds since start in `double`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25779#discussion_r2177009372
More information about the hotspot-gc-dev
mailing list