RFR: 8360540: nmethod entry barriers of new nmethods should be disarmed

Erik Österlund eosterlund at openjdk.org
Wed Jul 2 08:19:49 UTC 2025


On Wed, 25 Jun 2025 14:55:03 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

> Adding `disarm` calls as ZGC and ShenandoahGC already have (see JBS issue for more details). Tier1-4 tests have passed.
> 
> I will need reviews from GC experts to check for potentially problematic side effects.
> Note that `rebuild_code_roots()` disarms all nmethods during `G1FullCollector::complete_collection`, now.
> 
> Some stats (nmethod entry barrier hits in jvm98 with/without patch):
> 
> | GC       | before | after |
> | -------- | ------ | ----- |
> | G1       |   3339 |   127 |
> | Parallel |   3223 |  1141 |
> | Serial   |   3206 |  1142 |

This looks fine to me. The oops should be alive, and _gc_epoch is looking right.

-------------

Marked as reviewed by eosterlund (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/25982#pullrequestreview-2978195984


More information about the hotspot-gc-dev mailing list