RFR: 8361238: G1 tries to get CPU info from terminated threads at shutdown
Kim Barrett
kbarrett at openjdk.org
Wed Jul 2 16:01:51 UTC 2025
On Wed, 2 Jul 2025 07:57:28 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
> Hi all,
>
> please review this fix after the recent changes in void JDK-8274051 where G1 tries to get thread cpu time on already terminated threads.
>
> The fix is to move the printing/statistics before stopping the threads. This seems fine for the two implementors of the method.
>
> In a future change, since so few GCs implement `print_tracing_info`, the call should probably move to `stop()/begin_exit()`.
>
> Testing: gha
>
> Thanks,
> Thomas
Looks good.
-------------
Marked as reviewed by kbarrett (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26086#pullrequestreview-2979755321
More information about the hotspot-gc-dev
mailing list