RFR: 8359110: Log accumulated GC and process CPU time upon VM exit [v14]

Jonas Norlinder duke at openjdk.org
Wed Jul 2 16:50:43 UTC 2025


On Wed, 2 Jul 2025 11:24:09 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Jonas Norlinder has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Change output per discussion
>
> src/hotspot/share/gc/shared/collectedHeap.hpp line 135:
> 
>> 133:   NOT_PRODUCT(volatile size_t _promotion_failure_alot_gc_number;)
>> 134: 
>> 135:   static jlong _vmthread_cpu_time;
> 
> I wonder if it's more natural to make it non-static.

Could you please elaborate? Other variables like `static size_t _stack_chunk_max_size` is also static.

> src/hotspot/share/gc/shared/collectedHeap.hpp line 212:
> 
>> 210: 
>> 211:   // Stop any onging concurrent work and prepare for exit.
>> 212:   virtual void stop() = 0;
> 
> Why `= 0` instead of `{}` as before?

It was suggested by @stefank in above discussions. https://github.com/openjdk/jdk/pull/25779#discussion_r2162341225 Is this something you think we should revert?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25779#discussion_r2180532088
PR Review Comment: https://git.openjdk.org/jdk/pull/25779#discussion_r2180534726


More information about the hotspot-gc-dev mailing list