RFR: 8359110: Log accumulated GC and process CPU time upon VM exit [v14]
Jonas Norlinder
duke at openjdk.org
Thu Jul 3 07:15:43 UTC 2025
On Wed, 2 Jul 2025 21:11:04 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> I'd prefer not to, as it is strictly not GC-time and we may want to use these methods in other places in the future.
>
> That would result into inconsistency, because we surely treat them as gc-time here. It'd be super confusing if the def of gc-time is not coherent inside JVM.
OK, if we ever want to report these separately we can deal with that then. I will move it.
>> It was suggested by @stefank in above discussions. https://github.com/openjdk/jdk/pull/25779#discussion_r2162341225 Is this something you think we should revert?
>
> I understand the part of splitting it into two methods, but why making it pure-virtual? Wouldn't `{}` as before work?
Both works. I believe it was a stylistic choice.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25779#discussion_r2182033010
PR Review Comment: https://git.openjdk.org/jdk/pull/25779#discussion_r2182034682
More information about the hotspot-gc-dev
mailing list