RFR: 8359110: Log accumulated GC and process CPU time upon VM exit [v17]

Jonas Norlinder duke at openjdk.org
Thu Jul 3 08:50:46 UTC 2025


On Thu, 3 Jul 2025 08:14:04 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Jonas Norlinder has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 27 commits:
>> 
>>  - Move call to print_tracing_info
>>  - Merge branch 'master' into gc_cpu_time
>>  - Remove static and move string_dedup_cpu_time into elapsed_gc_cpu_time
>>  - Fixes after @albertnetymk review
>>  - Change output per discussion
>>  - Make stop protected, remove integer divison, remove unused method
>>  - Update closure name
>>  - vtime -> cpu_time and _vm_vtime -> _vmthread_cpu_time
>>  - Fixes after review from @stefank
>>  - Merge branch 'master' of github.com:JonasNorlinder/openjdk_jdk into gc_cpu_time
>>  - ... and 17 more: https://git.openjdk.org/jdk/compare/c75df634...f9c3aa64
>
> src/hotspot/share/runtime/cpuTimeCounters.hpp line 56:
> 
>> 54: 
>> 55: class CPUTimeCounters: public CHeapObj<mtServiceability> {
>> 56:   friend class CPUTimeScope;
> 
> I wonder if we avoid this. The public APIs should be enough.

get_instance() is private. It was not clear to me if we would want to change get_instance() to public

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25779#discussion_r2182226865


More information about the hotspot-gc-dev mailing list