RFR: 8359110: Log accumulated GC and process CPU time upon VM exit [v19]
Jonas Norlinder
duke at openjdk.org
Thu Jul 3 10:58:44 UTC 2025
On Thu, 3 Jul 2025 10:34:27 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:
>> Jonas Norlinder has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Remove friend class in CPUTimeCounters
>
> src/hotspot/share/gc/shared/vmThreadCpuTimeScope.hpp line 37:
>
>> 35: bool _enabled;
>> 36: bool _is_gc_operation;
>> 37: Thread* _thread;
>
> If this class is solely for vmthread, I guess using the more concrete type `VMThread` here seems more explicit.
OK, was storing it as `Thread` as it is only needed for `os::thread_cpu_time`. But now that we have renamed the class to something more specific it makes sense to be more explicit here.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25779#discussion_r2182487230
More information about the hotspot-gc-dev
mailing list