RFR: 8350621: Code cache stops scheduling GC

[Thomas Schatzl]

On Wed, 9 Jul 2025 17:32:25 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Hi all,
>> 
>>   please review this change to avoid CodeCache triggered GCs temporarily being ignored.
>> 
>> In particular, G1 does not make sure when its `collect()` method is called during a concurrent cycle, that a `Remark` pause that does code unloading etc. actually occurs after that request. This makes it so that some internal flag is not reset appropriately (via some callback to the caller). After this event, there will never be another attempt by the compiler threads to issue a garbage collection. The compiler threads are stuck until the next code unloading (caused by e.g. a regular concurrent cycle being triggered).
>> 
>> The [original PR](https://github.com/openjdk/jdk/pull/23656) also stated a similar with Parallel GC - however due to recent changes (https://bugs.openjdk.org/browse/JDK-8192647 and others) I do not think it is possible any more that the `collect()`call can silently be ignored. (I.e. gclocker could abort a full gc that is the only reason why code cache unloading and that callback will not occur as expected).
>> 
>> So for G1, the change makes the caller of `collect()` (i.e. the compiler thread) wait until that situation passes and retry. With that the compiler thread is sure that the callback the compiler threads are waiting for occurs. This does have the disadvantage that that compiler thread may not be available for compilation any more for a bit.
>> 
>> Testing: tier1-5, test case passing, failing before
>> 
>> Thanks,
>>   Thomas
>
> src/hotspot/share/gc/g1/g1CollectedHeap.cpp line 1757:
> 
>> 1755:     } else if (!GCCause::is_user_requested_gc(cause) &&
>> 1756:                // We can only skip CodeCache requested GCs if we are before marking.
>> 1757:                (!GCCause::is_codecache_requested_gc(cause) || op.marking_in_progress()) ) {
> 
> Wouldn't this be a lot simpler like this:
> 
> } else if (GCCause::is_codecache_requested_gc(cause) && op.marking_in_progress()) {
>   LOG_COLLECT_CONCURRENTLY_COMPLETE(cause, true);
>   return true;
> } else if (!GCCause::is_user_requested_gc(cause) && !GCCause::is_codecache_requested_gc(cause)) {
>   ... unchanged old code ...
> }
> 
> Of course, the codecache case needs some comments.

That's much nicer, thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26189#discussion_r2196818701